-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert plaintext protobuf into Scylla #247
Conversation
f0811ff
to
53f2559
Compare
Issues remaing: |
Do you want to just keep this open until 244 is finished? If it's broken rn probably no point to merge to develop. |
It works it just uses a bunch of memory (4gb/hour of data collected). 244 may be a pretty significant shift as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM lmk if you think changing those error msgs would be at all useful
Changes
Inserts plaintext protobuf into scylla. Steps:
Odysseus-Daemon
with the length delimited protobufPlaybackData
-1
if out of range.Changes outside of new insert:
Notes
Any other notes go here
Test Cases
To Do
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)Closes #243